Skip to content

fix: exclude more domains from being backed up by the system #4773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: exclude more domains from being backed up by the system #4773

wants to merge 1 commit into from

Conversation

lucasmz-dev
Copy link

tries* to fix #3465

Content

A simple change to exclude more domains in the backup rules xml configs

Motivation and context

Attempt to fix #3465

Tests

  • I didn't :(

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@lucasmz-dev lucasmz-dev requested a review from a team as a code owner May 25, 2025 11:13
@lucasmz-dev lucasmz-dev requested review from bmarty and removed request for a team May 25, 2025 11:13
@CLAassistant
Copy link

CLAassistant commented May 25, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@lucasmz-dev lucasmz-dev force-pushed the fix-backups branch 3 times, most recently from 12d442d to 5479ee0 Compare May 27, 2025 17:53
@lucasmz-dev
Copy link
Author

For context, this is the same as the "regular" Element does:

https://github.com/element-hq/element-android/blob/develop/vector-app/src/main/res/xml/data_extraction_rules.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty Awaiting requested review from bmarty bmarty is a code owner automatically assigned from element-hq/element-x-android-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element X allows device-to-device transfers, but doesn't result in a usable setup anyway
2 participants
@lucasmz-dev @CLAassistant